Skip to content

[O2B-1481] Env overview should correctly resize the table#2021

Merged
graduta merged 5 commits into
mainfrom
improv/O2B-1481/Env-overview-should-correctly-resize-the-table
Nov 18, 2025
Merged

[O2B-1481] Env overview should correctly resize the table#2021
graduta merged 5 commits into
mainfrom
improv/O2B-1481/Env-overview-should-correctly-resize-the-table

Conversation

@isaachilly
Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Table should resize correctly (always be able to see the pagination) according to screen size.

Notable changes for developers:

  • Environments overview model now extends the OverviewPageModel.

Changes made to the database:

  • N/A

Updated TABLEROW_HEIGHT to 58 and PAGE_USED_HEIGHT to 181 to reflect the current state of page.

Modified the related test to expect 9 environments per page instead of 10 due to the test browser now only having space for this many rows.
EnvironmentOverviewModel now extends OverviewPageModel, removing redundant pagination and data fetching logic.

The model's parent's loadOverview method is updated to use the new loading logic.

Component is sent whole model not just sections, given it has more utility now.
…odes

Added tests to verify that loadOverview does not trigger a load when infinite scroll is enabled, and does trigger a load when infinite scroll is disabled.
@isaachilly isaachilly self-assigned this Nov 18, 2025
@isaachilly isaachilly added frontend javascript Pull requests that update Javascript code labels Nov 18, 2025
@isaachilly isaachilly requested a review from graduta as a code owner November 18, 2025 13:20
@graduta graduta merged commit 7e0f365 into main Nov 18, 2025
38 of 39 checks passed
@graduta graduta deleted the improv/O2B-1481/Env-overview-should-correctly-resize-the-table branch November 18, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants